Q dev #33171
Closed
Q dev #33171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompt= "I do not think this L2 is following CDK coding guidelines. It missed some properties. Also, for constructs defined in cdk-lib, we do not import from the dependencies, but instead we depend on the modules defined in the project. We shuld use enum where it make sense, as it is a mandatory property. E.g. "engine" property. Given this, can you update the code for elasticache ?"
github-actions
bot
added
beginning-contributor
aws-cdk-automation
requested changes
Jan 26, 2025
Collaborator
aws-cdk-automation
left a comment
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ The title prefix of this pull request must be one of "feat|fix|build|chore|ci|docs|style|refactor|perf|test|revert"
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Sync
Description of changes
Syncing to main
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license